Fix 7 bugs from cross-toolbox Matlab vs Python audit#54
Merged
iahncajigas merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
Bugs fixed: - SignalObj.std(): use ddof=1 to match Matlab's std() (P1) - SignalObj.alignTime(): add bounds check matching Matlab (P2) - SpikeTrainCollection.psthGLM(): full GLM implementation replacing stub (P5) - SpikeTrainCollection.getNSTnames(): honor selectorArray parameter (P6) - SpikeTrainCollection.getUniqueNSTnames(): honor selectorArray parameter (P7) - SpikeTrainCollection.getNST(): resample to collection sampleRate on retrieval (P8) - CovariateCollection.isCovPresent(): fix off-by-one for index-based lookup (P9) Also adds AUDIT_REPORT.md with comprehensive cross-toolbox audit findings covering 11 Matlab bugs, 7 Python bugs, 19+ missing methods, and 18 behavioral differences. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive cross-toolbox audit comparing all Matlab nSTAT classes against their Python equivalents. This PR fixes 7 confirmed Python bugs and adds the full audit report.
Bugs Fixed
SignalObj.std()ddof=1to match Matlab'sstd()(wasddof=0)SignalObj.alignTime()minTime <= marker <= maxTimeSpikeTrainCollection.psthGLM()SpikeTrainCollection.getNSTnames()selectorArrayparameter (was returning all names)SpikeTrainCollection.getUniqueNSTnames()selectorArrayparameterSpikeTrainCollection.getNST()sampleRateon retrievalCovariateCollection.isCovPresent()index < numCov→index <= numCovAudit Report
Added
AUDIT_REPORT.mddocumenting:Test plan
--export-figuresisCovPresenttest updated to expect correct behavior (Matlab has the same off-by-one bug)🤖 Generated with Claude Code